Skip to content

Conversation

@mjaric
Copy link
Member

@mjaric mjaric commented May 14, 2025

No description provided.

@github-actions
Copy link

Tests summary

Finished in 0.2 seconds (0.2s async, 0.00s sync)
111 tests, 0 failures

Generating cover results ...

Percentage Module
 0.00% | Lora
 0.00% | Lora.DataCase
 0.00% | Lora.GameServer
 5.56% | Lora.Contract
 8.70% | Lora.GameSupervisor
20.83% | Lora.Game
79.07% | Lora.Deck
89.36% | Lora.Contracts.Lora
94.12% | Lora.Contracts.TrickTaking
97.62% | Lora.Score

100.00% | Lora.Application
100.00% | Lora.Contracts.ContractBehaviour
100.00% | Lora.Contracts.Hearts
100.00% | Lora.Contracts.JackOfClubs
100.00% | Lora.Contracts.KingHeartsLastTrick
100.00% | Lora.Contracts.Maximum
100.00% | Lora.Contracts.Minimum
100.00% | Lora.Contracts.Queens

100.00% Lora.Mailer
52.60% | Total

Coverage test failed, threshold not met:

Coverage:   52.60%
Threshold:  90.00%

Generated HTML coverage results in "cover" directory
==> lora_web
Cover compiling modules ...
Running ExUnit with seed: 332309, max_cases: 8

..........
Finished in 0.1 seconds (0.08s async, 0.06s sync)
Running ExUnit with seed: 332309, max_cases: 8

0 failures (10 tests)
37.39% coverage (80% is the minimum)

Coverage details
Percentage | Module
-----------|--------------------------
     0.00% | LoraWeb.Application
     0.00% | LoraWeb.Layouts
     0.00% | LoraWeb.PageController
     0.00% | LoraWeb.PageHTML
     0.00% | LoraWeb.Telemetry
    14.29% | LoraWeb.Test
    34.65% | LoraWeb.GameLive
    35.00% | LoraWeb.CoreComponents
    42.86% | LoraWeb.LobbyLive
    50.00% | LoraWeb.ErrorHTML
    80.00% | LoraWeb.Router
   100.00% | LoraWeb
   100.00% | LoraWeb.ConnCase
   100.00% | LoraWeb.Endpoint
   100.00% | LoraWeb.ErrorJSON
   100.00% | LoraWeb.Gettext
   100.00% | LoraWeb.LiveViewCase
   100.00% | LoraWeb.Presence
-----------|--------------------------
    37.39% | Total

Copy link
Member

@burmajam burmajam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tl;dr

mjaric added 8 commits May 15, 2025 17:35
vs code become slow and some changes were not persisted on disk

updated to vs code 100.2, will see if issue persists
@mjaric mjaric merged commit fe57228 into main May 16, 2025
1 check failed
@mjaric mjaric deleted the unit-testing-contracts branch May 16, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants